Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide request headers to download #10

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

konstantinoskostis
Copy link
Contributor

This commit provides an additional option to the
download method, that of request headers. From
now on users can add keys and values to request
headers, that will be sent to a downloader instance
and will be passed to the request that will fetch
the desired resource.

@konstantinoskostis konstantinoskostis added the enhancement New feature or request label Jul 4, 2019
@konstantinoskostis konstantinoskostis self-assigned this Jul 4, 2019
lib/ferto/client.rb Outdated Show resolved Hide resolved
lib/ferto/client.rb Outdated Show resolved Hide resolved
Copy link
Member

@oliakremmyda oliakremmyda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I have some minor final comments, and is ok by me.

spec/ferto/client_spec.rb Outdated Show resolved Hide resolved
spec/ferto/client_spec.rb Outdated Show resolved Hide resolved
This commit provides an additional option to the
download method, that of request headers. From
now on users can add keys and values to request
headers, that will be sent to a downloader instance
and will be passed to the request that will fetch
the desired resource.
Copy link
Member

@oliakremmyda oliakremmyda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@konstantinoskostis konstantinoskostis merged commit 7566a05 into master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants