-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide request headers to download #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantinoskostis
force-pushed
the
set_request_headers
branch
from
July 4, 2019 12:59
54b184c
to
6cce6d0
Compare
agis
reviewed
Jul 4, 2019
agis
reviewed
Jul 4, 2019
konstantinoskostis
force-pushed
the
set_request_headers
branch
from
July 4, 2019 14:23
6cce6d0
to
28b3022
Compare
oliakremmyda
reviewed
Jul 5, 2019
oliakremmyda
reviewed
Jul 5, 2019
konstantinoskostis
force-pushed
the
set_request_headers
branch
from
July 8, 2019 09:11
28b3022
to
cf5bc31
Compare
agis
approved these changes
Jul 9, 2019
oliakremmyda
reviewed
Jul 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I have some minor final comments, and is ok by me.
This commit provides an additional option to the download method, that of request headers. From now on users can add keys and values to request headers, that will be sent to a downloader instance and will be passed to the request that will fetch the desired resource.
konstantinoskostis
force-pushed
the
set_request_headers
branch
from
July 9, 2019 10:29
cf5bc31
to
8315dd3
Compare
oliakremmyda
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
konstantinoskostis
force-pushed
the
set_request_headers
branch
from
July 9, 2019 10:42
8315dd3
to
7566a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides an additional option to the
download method, that of request headers. From
now on users can add keys and values to request
headers, that will be sent to a downloader instance
and will be passed to the request that will fetch
the desired resource.