client: Add support for download_timeout, user_agent and aggr_proxy #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agis
reviewed
Apr 15, 2019
lib/ferto/client.rb
Outdated
| # @param aggr_timeout [Integer] the maximum time to wait for the resource | ||
| # to be downloaded in seconds, by default it uses the timeout set in | ||
| # the downloader's configuration | ||
| # @param aggr_useragent [String] the User-Agent string to use for |
There was a problem hiding this comment.
Note: This depends on the downloader implementation, however since we have no PR for that yet I'll write it here.
I believe we shouldn't limit this feature to the "User-Agent" header - we should allow setting any header the user wants. It might be a little bit more work to implement, but it's worth the effort. Otherwise, we'll have to change the code in downloader and ferto every time we want to set another header.
Also, is there a reason to tie this to the Aggregation, as opposed to the Job?
avgerin0s
changed the title
0xdiba
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
👍
Let's have a link to the feature PR just for reference: skroutz/downloader#14
konstantinoskostis
approved these changes
Apr 18, 2019
- `download_timeout` option is used to define the maximum time to wait for a resource download. If unset the downloader service does not use a timeout. - `user_agent` option is used to define the User-Agent string to use for a resource download. If unset the downloader service uses its preconfigured value. - `aggr_proxy` option is used to define the HTTP proxy to use for a resource download. If unset the downloader decides whether to use a proxy or not based on the environment variables like HTTP_PROXY and HTTPS_PROXY
oliakremmyda
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download_timeoutoption is used to define the maximum time to wait for aresource download. If unset the downloader does not use a timeout.
user_agentoption is used to define the User-Agent string to usefor a resource download. If unset the downloader service uses its
preconfigured value.
aggr_proxyoption is used to define the HTTP proxy to use for aresource download. If unset the downloader ues no HTTP proxy for the
download.