Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new poetry install method #1126

Merged
merged 16 commits into from
Sep 7, 2022
Merged

Update new poetry install method #1126

merged 16 commits into from
Sep 7, 2022

Conversation

jdb78
Copy link
Collaborator

@jdb78 jdb78 commented Sep 5, 2022

Description

This PR updates the poetry install method - fixing the CI.

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Base: 90.22% // Head: 90.30% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (030d735) compared to base (0e31e52).
Patch coverage: 86.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
+ Coverage   90.22%   90.30%   +0.07%     
==========================================
  Files          31       31              
  Lines        4676     4691      +15     
==========================================
+ Hits         4219     4236      +17     
+ Misses        457      455       -2     
Flag Coverage Δ
cpu 90.30% <86.66%> (+0.07%) ⬆️
pytest 90.30% <86.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytorch_forecasting/metrics/distributions.py 98.98% <ø> (ø)
pytorch_forecasting/metrics/point.py 91.91% <ø> (ø)
pytorch_forecasting/data/encoders.py 87.43% <80.00%> (-0.31%) ⬇️
pytorch_forecasting/data/examples.py 96.66% <100.00%> (ø)
pytorch_forecasting/metrics/base_metrics.py 80.64% <100.00%> (+0.44%) ⬆️
pytorch_forecasting/models/nn/rnn.py 92.40% <0.00%> (+5.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdb78 jdb78 merged commit 7f67513 into master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants