Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Fix dependency issues and CI runners: numpy2, optuna, requests, MacOS MPS #1599

Merged
merged 8 commits into from
Aug 25, 2024
Merged

[MNT] Fix dependency issues and CI runners: numpy2, optuna, requests, MacOS MPS #1599

merged 8 commits into from
Aug 25, 2024

Conversation

XinyuWuu
Copy link
Member

@XinyuWuu XinyuWuu commented Aug 23, 2024 •
edited by fkiraly
Loading

Fixes #1594, fixes #1595, fixes #1596

Added or moved some dependencies to core dependency set.

Fixed some numpy2 and optuna-integrations problems.

requests replaced by urllib.request.urlretrieve.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@XinyuWuu XinyuWuu mentioned this pull request Aug 23, 2024
Open
21 tasks
fkiraly
fkiraly requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Could you kindly split this up into two PR, "notebook" and "other" fixes?

@XinyuWuu XinyuWuu mentioned this pull request Aug 24, 2024
Merged
@XinyuWuu XinyuWuu changed the title [BUG] Fix Tutorial Notebooks [BUG] Fix some package problems numpy2 optuna and requests Aug 24, 2024
@XinyuWuu
Copy link
Member Author

Nice!

Could you kindly split this up into two PR, "notebook" and "other" fixes?

Notebooks are seperated to #1615.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (523171a) to head (f93b1e2).
Report is 57 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
- Coverage   90.05%   90.04%   -0.01%     
==========================================
  Files          30       30              
  Lines        4724     4722       -2     
==========================================
- Hits         4254     4252       -2     
  Misses        470      470
Flag Coverage Δ
cpu 90.04% <100.00%> (-0.01%) ⬇️
pytest 90.04% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XinyuWuu
Copy link
Member Author

@fkiraly It seems that new macos runners with Apple silicon don’t have access to MPS hardware. Setting it to macos-13 solved the problems.

@fkiraly fkiraly changed the title [BUG] Fix some package problems numpy2 optuna and requests [MNT] Fix dependency issues and CI runners: numpy2, optuna, requests, MacOS MPS Aug 25, 2024
@fkiraly fkiraly added dependencies Pull requests that update a dependency file maintenance Continuous integration, unit testing & package distribution labels Aug 25, 2024
fkiraly
fkiraly approved these changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the PR.

@fkiraly fkiraly merged commit d82eaaf into sktime:master Aug 25, 2024
12 checks passed
@fkiraly fkiraly mentioned this pull request Aug 25, 2024
Closed
@XinyuWuu XinyuWuu mentioned this pull request Aug 26, 2024
Merged
fkiraly pushed a commit that referenced this pull request Oct 3, 2024
@XinyuWuu
[MNT] Relax numpy bound to numpy<3.0.0 (#1624)
53a1c41 
Relaxes `numpy` bound to `numpy<3.0.0`.

(updated by @fkiraly - removed the `optuna` bound which has been dealt
with in #1629)

---

It should work with newer `numpy` and `optuna` version after #1599.
@tmct tmct mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MNT] MPS backend test failures on MacOS [MNT] optuna>=3.3.0 compatibility [MNT] numpy 2 compatibility
3 participants
@XinyuWuu @codecov-commenter @fkiraly