Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

&felipeangelimvieira, yarnabrina [MNT] CI step to test that notebooks run #1621

Merged
merged 14 commits into from
Aug 25, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Aug 25, 2024

This adds a CI step to run all the tutorial notebooks.

The test passes if all tutorial notebooks run without error, and can be used to test the fixes in #1615

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Aug 25, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented Aug 25, 2024

FYI @XinyuWuu, @yarnabrina, any ideas why the GHA cannot see the sh script?

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (862c5da) to head (4f21f7b).
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1621   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files          30       30           
  Lines        4722     4722           
=======================================
  Hits         4259     4259           
  Misses        463      463           
Flag Coverage Δ
cpu 90.19% <ø> (ø)
pytest 90.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Aug 25, 2024

credits:


[tool.setuptools]
py-modules = ["pytorch_forecasting"]

[build-system]
build-backend = "setuptools.build_meta"
requires = [
  "setuptools>61",
]

suggestio due to @felipeangelimvieira

@fkiraly
Copy link
Collaborator Author

fkiraly commented Aug 25, 2024

oh, still permission denied

@yarnabrina
Copy link
Member

I think you haven't changed file level permission, e.g. with chmod. Do you want me to push a test commit in this branch?

@fkiraly
Copy link
Collaborator Author

fkiraly commented Aug 25, 2024

I think you haven't changed file level permission, e.g. with chmod. Do you want me to push a test commit in this branch?

would be appreciated! Probably a problem with my windows

@yarnabrina
Copy link
Member

yarnabrina commented Aug 25, 2024

I think it's working now, please take a look. All I did is this:

cd build_tools
chmod +x run_examples.sh

CI failed because of code issue, the permission one is resolved.

pyproject.toml Outdated Show resolved Hide resolved
@fkiraly
Copy link
Collaborator Author

fkiraly commented Aug 25, 2024

Nice! The test now runs as intended!

The failure is genuine and has identical root cause with #1614

Co-authored-by: Anirban Ray <39331844+yarnabrina@users.noreply.github.com>
@fkiraly fkiraly changed the title [MNT] CI step to test that notebooks run &felipeangelimvieira, yarnabrina [MNT] CI step to test that notebooks run Aug 25, 2024
@fkiraly fkiraly merged commit ccb50ab into master Aug 25, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants