Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics #491

Merged
merged 2 commits into from
May 9, 2021
Merged

Fix metrics #491

merged 2 commits into from
May 9, 2021

Conversation

jdb78
Copy link
Collaborator

@jdb78 jdb78 commented May 9, 2021

Description

Checklist

  • Amended changelog for large changes (and added myself there as contributor)
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #491 (a988608) into master (e821832) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
- Coverage   89.21%   89.10%   -0.11%     
==========================================
  Files          24       24              
  Lines        3682     3682              
==========================================
- Hits         3285     3281       -4     
- Misses        397      401       +4     
Flag Coverage Δ
cpu 89.10% <50.00%> (-0.11%) ⬇️
pytest 89.10% <50.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytorch_forecasting/metrics.py 93.45% <50.00%> (ø)
pytorch_forecasting/models/nn/rnn.py 87.34% <0.00%> (-5.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e821832...a988608. Read the comment docs.

@jdb78 jdb78 merged commit 94305a3 into master May 9, 2021
@jdb78 jdb78 deleted the fix/metrics-device branch May 23, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeepAR Example Failure on Colab - Expected all tensors to be on the same device
2 participants