Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/better-time-series-docs #518

Merged
merged 10 commits into from
Jun 4, 2021
Merged

Conversation

jdb78
Copy link
Collaborator

@jdb78 jdb78 commented May 23, 2021

Description

This PR does some housekeeping for timeseries and gives more control over sampling.

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jdb78 jdb78 force-pushed the feature/better-time-series-docs branch from 589deef to 0cca0f8 Compare May 23, 2021 17:43
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2021

Codecov Report

Merging #518 (d22ebdc) into master (cf26008) will increase coverage by 0.23%.
The diff coverage is 92.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   89.08%   89.31%   +0.23%     
==========================================
  Files          24       24              
  Lines        3684     3698      +14     
==========================================
+ Hits         3282     3303      +21     
+ Misses        402      395       -7     
Flag Coverage Δ
cpu 89.31% <92.38%> (+0.23%) ⬆️
pytest 89.31% <92.38%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytorch_forecasting/metrics.py 93.22% <ø> (ø)
pytorch_forecasting/models/basic_rnn/__init__.py 0.00% <0.00%> (ø)
pytorch_forecasting/data/timeseries.py 93.35% <86.66%> (+0.62%) ⬆️
pytorch_forecasting/models/deepar/__init__.py 97.54% <88.88%> (-1.63%) ⬇️
pytorch_forecasting/utils.py 80.98% <91.30%> (+1.99%) ⬆️
pytorch_forecasting/models/base_model.py 88.19% <96.42%> (+0.18%) ⬆️
pytorch_forecasting/__init__.py 100.00% <100.00%> (ø)
pytorch_forecasting/models/mlp/__init__.py 100.00% <100.00%> (ø)
pytorch_forecasting/models/nbeats/__init__.py 93.57% <100.00%> (-0.12%) ⬇️
pytorch_forecasting/models/rnn/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf26008...d22ebdc. Read the comment docs.

@jdb78 jdb78 merged commit d6a009d into master Jun 4, 2021
@jdb78 jdb78 deleted the feature/better-time-series-docs branch May 23, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants