Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optimizer initialization flexible #602

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Conversation

jdb78
Copy link
Collaborator

@jdb78 jdb78 commented Jul 7, 2021

Description

Optimizer can be initialized by passing string, class or function + fixing transformation for MLP

Checklist

  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@jdb78 jdb78 linked an issue Jul 7, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #602 (bc62f84) into master (007013e) will decrease coverage by 0.96%.
The diff coverage is 80.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
- Coverage   90.54%   89.58%   -0.97%     
==========================================
  Files          20       24       +4     
  Lines        3312     3716     +404     
==========================================
+ Hits         2999     3329     +330     
- Misses        313      387      +74     
Flag Coverage Δ
cpu 89.58% <80.37%> (-0.97%) ⬇️
pytest 89.58% <80.37%> (-0.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytorch_forecasting/models/basic_rnn/__init__.py 0.00% <0.00%> (ø)
pytorch_forecasting/data/encoders.py 86.49% <78.12%> (+1.77%) ⬆️
pytorch_forecasting/models/nbeats/__init__.py 93.57% <83.33%> (-0.12%) ⬇️
pytorch_forecasting/models/base_model.py 89.92% <84.15%> (+1.59%) ⬆️
pytorch_forecasting/utils.py 81.94% <86.48%> (+1.38%) ⬆️
pytorch_forecasting/data/timeseries.py 93.35% <87.50%> (+0.32%) ⬆️
pytorch_forecasting/models/deepar/__init__.py 97.54% <88.23%> (-0.97%) ⬇️
pytorch_forecasting/metrics.py 93.45% <89.65%> (-0.72%) ⬇️
pytorch_forecasting/__init__.py 100.00% <100.00%> (ø)
pytorch_forecasting/data/__init__.py 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270e267...bc62f84. Read the comment docs.

@jdb78 jdb78 merged commit 1c71b7c into master Jul 7, 2021
@jdb78 jdb78 deleted the feature/better-optimizer-init branch July 7, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Train without validation set
2 participants