Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance issues #688

Merged
merged 9 commits into from
Sep 26, 2021
Merged

Maintenance issues #688

merged 9 commits into from
Sep 26, 2021

Conversation

jdb78
Copy link
Collaborator

@jdb78 jdb78 commented Sep 25, 2021

Description

This PR ...

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #688 (95d8491) into master (d90fbcb) will increase coverage by 0.13%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
+ Coverage   89.87%   90.01%   +0.13%     
==========================================
  Files          24       24              
  Lines        3714     3734      +20     
==========================================
+ Hits         3338     3361      +23     
+ Misses        376      373       -3     
Flag Coverage Δ
cpu 90.01% <96.15%> (+0.13%) ⬆️
pytest 90.01% <96.15%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytorch_forecasting/data/timeseries.py 93.35% <ø> (ø)
pytorch_forecasting/models/base_model.py 90.07% <96.00%> (+0.14%) ⬆️
pytorch_forecasting/data/encoders.py 86.53% <100.00%> (ø)
pytorch_forecasting/models/nn/rnn.py 92.40% <0.00%> (+5.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90fbcb...95d8491. Read the comment docs.

@jdb78 jdb78 mentioned this pull request Sep 26, 2021
4 tasks
@jdb78 jdb78 merged commit e5af895 into master Sep 26, 2021
@jdb78 jdb78 deleted the fix/update-issues branch May 23, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running TFT tutorial: AttributeError: 'functools.partial' object has no attribute '__name__'
2 participants