Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for GPU and MultiLoss #908

Merged
merged 7 commits into from
Mar 24, 2022
Merged

Fixes for GPU and MultiLoss #908

merged 7 commits into from
Mar 24, 2022

Conversation

jdb78
Copy link
Collaborator

@jdb78 jdb78 commented Mar 24, 2022

Description

This PR fixes issues with training on GPU and MultiLoss

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #908 (022147c) into master (af9e1d3) will decrease coverage by 0.65%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   89.88%   89.22%   -0.66%     
==========================================
  Files          26       26              
  Lines        4200     4224      +24     
==========================================
- Hits         3775     3769       -6     
- Misses        425      455      +30     
Flag Coverage Δ
cpu 89.22% <79.31%> (-0.66%) ⬇️
pytest 89.22% <79.31%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ing/models/temporal_fusion_transformer/__init__.py 99.56% <ø> (ø)
pytorch_forecasting/metrics.py 87.32% <77.77%> (-4.65%) ⬇️
pytorch_forecasting/data/encoders.py 88.30% <100.00%> (-0.30%) ⬇️
pytorch_forecasting/models/base_model.py 88.82% <100.00%> (ø)
pytorch_forecasting/models/nn/rnn.py 87.34% <0.00%> (-5.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9e1d3...022147c. Read the comment docs.

@jdb78 jdb78 merged commit 4854c32 into master Mar 24, 2022
@jdb78 jdb78 deleted the feature/gpu-fixes branch May 23, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants