Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#19 Added .NET 8 support #20

Merged
merged 3 commits into from
Jan 27, 2024
Merged

#19 Added .NET 8 support #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59dc4aa
#19 Added .NET 8 support
skuill Jan 27, 2024
6739ab8
#19 Fixed Client framework version
skuill Jan 27, 2024
c17b817
#19 Update README.md
skuill Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/cicd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
- uses: actions/setup-dotnet@v3
with:
dotnet-version: "7.0.x"
- uses: actions/setup-dotnet@v3
with:
dotnet-version: "8.0.x"
- name: Set RELEASE_VERSION
run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
- name: Restore Packages
Expand Down Expand Up @@ -60,11 +63,13 @@ jobs:
zip -j LyricsScraperNET-net5.0.zip LyricsScraperNET/bin/Release/net5.0/*
zip -j LyricsScraperNET-net6.0.zip LyricsScraperNET/bin/Release/net6.0/*
zip -j LyricsScraperNET-net7.0.zip LyricsScraperNET/bin/Release/net7.0/*
zip -j LyricsScraperNET-net8.0.zip LyricsScraperNET/bin/Release/net8.0/*
gh release upload "$RELEASE_VERSION" \
"LyricsScraperNET-netstandard2.0.zip" \
"LyricsScraperNET-netstandard2.1.zip" \
"LyricsScraperNET-net5.0.zip" \
"LyricsScraperNET-net6.0.zip" \
"LyricsScraperNET-net7.0.zip" \
"LyricsScraperNET-net8.0.zip" \
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4 changes: 2 additions & 2 deletions LyricsScraperNET.Client/LyricsScraperNET.Client.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net7.0;net6.0;net5.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net8.0;net7.0;net6.0;net5.0;netcoreapp3.1</TargetFrameworks>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
3 changes: 3 additions & 0 deletions LyricsScraperNET.Client/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ static async Task Main()
Console.WriteLine($"\r\nThis lyric was found by [{result.ExternalProviderType}]\r\n");
Console.ResetColor();

Console.ForegroundColor = ConsoleColor.DarkGray;
Console.WriteLine("Press any key to exit..");
Console.ResetColor();
Console.ReadLine();
}

Expand Down
2 changes: 1 addition & 1 deletion LyricsScraperNET.TestShared/LyricsScraperNET.TestShared.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net8.0;net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion LyricsScraperNET/LyricsScraperNET.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net8.0;net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0</TargetFrameworks>
<LangVersion>9.0</LangVersion>
<Nullable>enable</Nullable>
<PackageId>LyricsScraperNET</PackageId>
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ LyricsScraperNET is a library for .NET that provides an API to search for lyrics

## Features

* ✅ Supports multiple frameworks `.NET Standard 2.X`, `.NET 5`, `.NET 6`, `.NET 7`
* ✅ Supports multiple frameworks `.NET Standard 2.X`, `.NET 5`, `.NET 6`, `.NET 7`, `.NET 8`
* ✅ Logging supported.
* ✅ Modular structure, for easy testing.
* ✅ Multiple ways how to configure.
Expand Down
2 changes: 1 addition & 1 deletion Tests/LyricsScraperNET.IntegrationTest/LyricsScraperNET.IntegrationTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net7.0</TargetFrameworks>
<TargetFrameworks>net8.0</TargetFrameworks>
<LangVersion>9.0</LangVersion>
<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion Tests/LyricsScraperNET.UnitTest/LyricsScraperNET.UnitTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net7.0;net6.0;net5.0;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net8.0;net7.0;net6.0;net5.0;netcoreapp3.1</TargetFrameworks>
<LangVersion>9.0</LangVersion>
<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
Loading