Simplify our eval() method. #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is the first in a chain that will close #94, by simplifying our eval method. Here we've recognized that all of our simple types return themselves when they're evaluated - so we've created a simple "IsSimpleType" in our primitive interface. This makes it easy for simple things to return themselves, and no longer need to have a special case.
This has two goals: * Isolates the special forms in one location. * Removes the clutter from our eval method.
We still need to rework the struct-stuff, but I'm happier already.
Change the parseing of numbers to use 64-bit too.
* Move the type-checking into a function. * Update the variadic argument as we go around the loop
Sample code:
```lisp
;; define a structure
(struct animal name species)
;; create some instances of that structure
(set! cat (animal "tibs" "cat"))
(set! dog (animal "spot" "dog"))
;; Create a function using that structure as a typed-parameter
(set! greet (fn* (an:animal)
"Greet an animal"
(print "Hello %s you're the best %s I've ever seen!"
(animal.name an) (animal.species an))))
(greet cat)
(greet dog)
;;
;; Error executing types.lisp:
;; TypeError - argument an to greet was supposed to be animal, got string
;;
;; (greet "Steve")
;;
;; Error executing types.lisp:
;; TypeError - argument an to greet was supposed to be animal, got number
;;
;; (greet 3)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the first in a chain that will close #94, by simplifying our eval method.
Here we've recognized that all of our simple types return themselves when they're evaluated - so we've created a simple "IsSimpleType" in our primitive interface.
This makes it easy for simple things to return themselves, and no longer need to have a special case.