Fix RC conversion

sky-uk · Aug 31, 2022 · 72f7fc8 · 72f7fc8
1 parent b38e159
commit 72f7fc8
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/apis/pipelines/v1alpha2/runconfiguration_conversion.go b/apis/pipelines/v1alpha2/runconfiguration_conversion.go
@@ -10,6 +10,9 @@ func (src *RunConfiguration) ConvertTo(dstRaw conversion.Hub) error {
 
 	dst.ObjectMeta = src.ObjectMeta
 	dst.Spec.RuntimeParameters = mapToNamedValues(src.Spec.RuntimeParameters)
+	dst.Spec.Pipeline = v1alpha3.PipelineIdentifier{Name: src.Spec.Pipeline.Name, Version: src.Spec.Pipeline.Version}
+	dst.Spec.Schedule = src.Spec.Schedule
+	dst.Spec.ExperimentName = src.Spec.ExperimentName
 	dst.Status = v1alpha3.RunConfigurationStatus(src.Status)
 
 	return nil
@@ -25,6 +28,9 @@ func (dst *RunConfiguration) ConvertFrom(srcRaw conversion.Hub) error {
 	if err != nil {
 		return err
 	}
+	dst.Spec.Pipeline = PipelineIdentifier{Name: src.Spec.Pipeline.Name, Version: src.Spec.Pipeline.Version}
+	dst.Spec.Schedule = src.Spec.Schedule
+	dst.Spec.ExperimentName = src.Spec.ExperimentName
 	dst.Status = RunConfigurationStatus(src.Status)
 
 	return nil

diff --git a/apis/pipelines/v1alpha2/runconfiguration_conversion_test.go b/apis/pipelines/v1alpha2/runconfiguration_conversion_test.go
@@ -29,6 +29,10 @@ var _ = Context("RunConfiguration Conversion", func() {
 			dst := v1alpha3.RunConfiguration{}
 
 			Expect(src.ConvertTo(&dst)).To(Succeed())
+			Expect(dst.Spec.Schedule).To(Equal(src.Spec.Schedule))
+			Expect(dst.Spec.ExperimentName).To(Equal(src.Spec.ExperimentName))
+			Expect(dst.Spec.Pipeline.Name).To(Equal(src.Spec.Pipeline.Name))
+			Expect(dst.Spec.Pipeline.Version).To(Equal(src.Spec.Pipeline.Version))
 			Expect(dst.ObjectMeta).To(Equal(src.ObjectMeta))
 			Expect(dst.Status.Status).To(Equal(src.Status.Status))
 			Expect(dst.Status.ObservedPipelineVersion).To(Equal(src.Status.ObservedPipelineVersion))
@@ -65,6 +69,10 @@ var _ = Context("RunConfiguration Conversion", func() {
 			dst := RunConfiguration{}
 
 			Expect(dst.ConvertFrom(src)).To(Succeed())
+			Expect(dst.Spec.Schedule).To(Equal(src.Spec.Schedule))
+			Expect(dst.Spec.ExperimentName).To(Equal(src.Spec.ExperimentName))
+			Expect(dst.Spec.Pipeline.Name).To(Equal(src.Spec.Pipeline.Name))
+			Expect(dst.Spec.Pipeline.Version).To(Equal(src.Spec.Pipeline.Version))
 			Expect(dst.ObjectMeta).To(Equal(src.ObjectMeta))
 			Expect(dst.Status.Status).To(Equal(src.Status.Status))
 			Expect(dst.Status.ObservedPipelineVersion).To(Equal(src.Status.ObservedPipelineVersion))