Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force serialisation of name and values in NamedValue #165

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Force serialisation of name and values in NamedValue #165

merged 2 commits into from
Sep 12, 2022

Conversation

paoloambrosio-skyuk
Copy link
Contributor

After conversion from v1alpha2 to v1alpha3, environment variables and Beam arguments with empty values are serialised as follows:

- name: empty value
- name: not empty value
  value: something

This change forces the serialisation to output the value even when empty:

- name: empty value
  value: ""
- name: not empty value
  value: something

@paoloambrosio-skyuk @jmendesky
Force serialisation of name/values in NamedValue
5440634 
Co-authored-by: Jonas Mende <jonas.mende@sky.uk>
paoloambrosio-skyuk
paoloambrosio-skyuk commented Sep 12, 2022
View reviewed changes
apis/config/v1alpha2/kfp_controller_config_types.go
Comment on lines -15 to -17
Multiversion bool `json:"multiversion,omitempty"`

DefaultBeamArgs []apis.NamedValue `json:"defaultBeamArgs,omitempty"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was incorrectly recreated in #157 in v1alpha3 format, after having been removed in #154.

jmendesky
jmendesky previously approved these changes Sep 12, 2022
View reviewed changes
@paoloambrosio-skyuk @jmendesky
Revert v1alpha2 config to its original form
10f047b 
Co-authored-by: Jonas Mende <jonas.mende@sky.uk>
@paoloambrosio-skyuk paoloambrosio-skyuk merged commit e793e4e into master Sep 12, 2022
@paoloambrosio-skyuk paoloambrosio-skyuk deleted the always-serialise-namedvalues branch September 12, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmendesky jmendesky jmendesky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paoloambrosio-skyuk @jmendesky