-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log-based events #311
Merged
Merged
Log-based events #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmendesky
force-pushed
the
283-log-based-events
branch
5 times, most recently
from
January 26, 2024 18:27
757a80f
to
6f611a9
Compare
grahamia
force-pushed
the
283-log-based-events
branch
8 times, most recently
from
February 1, 2024 19:50
9e6ff39
to
d2ef78a
Compare
jmendesky
force-pushed
the
283-log-based-events
branch
3 times, most recently
from
February 1, 2024 21:30
811e3df
to
8f5c333
Compare
grahamia
force-pushed
the
283-log-based-events
branch
5 times, most recently
from
February 9, 2024 12:23
83b6fc4
to
0871140
Compare
Co-authored-by: Ian Graham <ian.graham@sky.uk>
… runconfiguration for provider sa Co-authored-by: Jonas Mende <jonas.mende@sky.uk>
Co-authored-by: Jonas Mende <jonas.mende@sky.uk>
jmendesky
force-pushed
the
283-log-based-events
branch
from
February 12, 2024 16:55
09933f5
to
75335e1
Compare
Co-authored-by: Jonas Mende <jonas.mende@sky.uk>
grahamia
force-pushed
the
283-log-based-events
branch
2 times, most recently
from
February 13, 2024 13:16
ae5888d
to
7b2d02a
Compare
Co-authored-by: Jonas Mende <jonas.mende@sky.uk>
jmendesky
force-pushed
the
283-log-based-events
branch
from
February 13, 2024 13:18
7b2d02a
to
66ffe80
Compare
grahamia
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #283
Replaces the existing setup for VAI run completion events with log-based events directly from Vertex AI/PubSub. This simplifies the architecture as the eventsource server and reduces the amount of API calls as it no longer needs to poll the Vertex AI API for state changes. Instead, events will be emitted b u Vertex AI on pipelne run completion and the eventsource server just needs to query once and populate run events. For resiliency, the eventsource server still NACKs messages in case of errors.
Tasks