Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace 2017.06 #373

Merged
merged 215 commits into from
Jun 21, 2017
Merged

Marketplace 2017.06 #373

merged 215 commits into from
Jun 21, 2017

Conversation

Joeper214
Copy link
Contributor

@Joeper214 Joeper214 commented Mar 3, 2017

Changelog

Features

  • Improve Zabbix in Project Prompt Message
  • Warning Text on Change scale modal
  • Improve DB manangement
  • AWSpec test CRUD feature
  • CloudFormation Apply Date History
  • From TSD to Typings
  • Fetch Latest AWS regions
  • Add log Notification after yum update execution is successful
  • Specify Subnet and VPC on initial deployment
  • Reflect ANSI terminal character color/highlighting

Update process

cd YOUR_SKYHOPPER_DIRECTORY
bundle install --path vendor/bundle
bundle exec rake db:migrate RAILS_ENV=production
bundle exec rake db:seed RAILS_ENV=production
cd frontend/
npm i
gulp type
gulp ts
cd ..

Joeper214 and others added 30 commits July 27, 2016 16:16
@@ -122,11 +142,14 @@ def chef_create
CfTemplate
# rubocop:enable Lint/Void

cf_params = Rails.cache.fetch(CF_PARAMS_KEY) || {}
Rails.cache.delete(CF_PARAMS_KEY)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop]

  • Metrics/BlockLength: Block has too many lines. [43/25]

@skyarch-networks
Copy link
Owner

Click here if you want to create rubocop's auto-correct Pull Request
Auto Correct by SideCI

See the documentation if you want to get more information about auto-correct.
Document

@Joeper214
Copy link
Contributor Author

Maybe we can release a new version today? @root-beer

@root-beer
Copy link
Collaborator

It seems this branch has a bug.
roles: [null, null]
2017-06-01 17 27 45

@Joeper214
Copy link
Contributor Author

Oh, Can you identify which part is it? Then I'll create a PR for this. Does it occur in other branches ex develop?

@root-beer
Copy link
Collaborator

develop is Okay. But master has a problem.

@root-beer
Copy link
Collaborator

I guess it occurs when ridley's version is old.

@Joeper214
Copy link
Contributor Author

Joeper214 commented Jun 1, 2017

maybe because develop branch has a lot of updates and fixes.

Like this #397

So, maybe we need to release pre-release v1.29.0 before releasing a new release in marketplace branch.

@Joeper214
Copy link
Contributor Author

Yeah . the ridley update was the issue.

@root-beer
Copy link
Collaborator

Sorry. The problem occurs because I'm using Ruby 2.3. This branch works with Ruby 2.2, so there is no problem. 🙇

@Joeper214
Copy link
Contributor Author

Joeper214 commented Jun 12, 2017

But I still encountered the Ridley Error message when trying to view the infrastructure EC2 instance.

So, It is better to set the Ridley update from develop branch before releasing this branch.

@Joeper214 Joeper214 changed the title [WIP] Marketplace Features Marketplace 2017.06 Jun 21, 2017
@Joeper214 Joeper214 merged commit b022b44 into aws-marketplace Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants