Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move migration code into Debian scripts #1070

Closed
jdknives opened this issue Jan 26, 2022 · 2 comments
Closed

Move migration code into Debian scripts #1070

jdknives opened this issue Jan 26, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@jdknives
Copy link
Member

Feature description

We currently handle config migrations and other upgrading procedures in the Skywire Visor binary as we previously did not have a pacakging system available to do these checks with. That is less than optimal and should be moved out of the binary and into the Debian scripts as it is easier to handle and should be less error prone hopefully.

@jdknives jdknives added the enhancement New feature or request label Jan 26, 2022
@0pcom
Copy link
Collaborator

0pcom commented Jan 26, 2022

This is already present in the packages if I understand you correctly.

After the first time I ran into issues with the config not working with the upgraded visor, I started generating (or regenerating) the config with skywire-cli in the skywire-autoconfig script on every update of the package. That script is called on installation and updates as part of the postinstall process.

The config for the visor mode (remote hypervisor) is not currently updated because it is created by the user

but the only reason this config was not updated was, at the time, the flag to retain the hypervisor configuration was not present.

We have that now and it's an easy check for the presence of the second config file and to update it if it exists, with the flag to retain the configured hypervisors (-x flag?)

@mrpalide I cannot find that flag anywhere, I thought you had told me about it previously?

On the next versioned release of skywire all the fixes will be integrated to the skywire-autoconfig script in the packages.

It should be safe to remove the config migration / update code from the visor for the next release.

@jdknives
Copy link
Member Author

Postponed to v0.7.0. Implemented binary updater migration in #1092

@jdknives jdknives closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants