Migrate update logic to Debian package #1076
Conversation
pkg/util/updater/updater.go
Outdated
| u.log.Warnf("%v is not found in update, skipping", binary) | ||
| return nil | ||
| func (u *Updater) addRepo() error { | ||
| if err := exec.Command("sudo", "add-apt-repository", "deb http://176.9.28.105 sid main").Run(); err != nil { |
There was a problem hiding this comment.
Can we use the domain here? It is deb.skywire.skycoin.com
There was a problem hiding this comment.
Mh, I used URLs in wiki page that Moses created. I'll change it.
pkg/util/updater/updater.go
Outdated
|
|
||
| if _, err := io.Copy(out, resp.Body); err != nil { | ||
| return "", err | ||
| func (u *Updater) restartBoard() { |
There was a problem hiding this comment.
Yes, I thought, based on logic of Moses Debian package. I'll check it with him again.
There was a problem hiding this comment.
I change it to restart service, not the board at all.
@jdknives you are referring to issue #1070? @mrpalide why are we doing repository configuration here? Configuring the repository initially is probably not desirable for users if it was not already configured. They probably downloaded it directly. the In the second place nothing else will run after that. The function won't return anything, the process will be killed. A new instance may start but there is no way to know and not a good way to test. you are uninstalling the program that is currently executing this command. the process will be killed. |
mrpalide
changed the title
Did you run
make format && make check? YesFixes #1070
Changes:
How to test this PR:
GOOS=linux GOARCH=arm64 GOARM=6 make build BUILDTAG=linux_arm64. (I usearm64because of my board RPi4, you should use your own board architect)./usr/bin:skywire-cliskywire-visorsetup-nodeapps/*