Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wait group to ensure all components shutdown before Visor.Close returns. #170

Closed
evanlinjin opened this issue Feb 28, 2020 · 0 comments
Closed

Use wait group to ensure all components shutdown before Visor.Close returns. #170

evanlinjin opened this issue Feb 28, 2020 · 0 comments
Assignees
@evanlinjin

Comments

@evanlinjin
Copy link
Contributor

Feature description

We should wait until all go routines of components shutdown before Visor.Close returns.
This should ensure a clean shutdown and may guarantee a successful restart.

Describe the solution you'd like
Passing a sync.WaitGroup to all go routines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evanlinjin evanlinjin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Darkren @evanlinjin