Improve visor config and startup/shutdown logic. #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkren
suggested changes
May 14, 2020
| if !ok { | ||
| return ErrAppNotFound | ||
| } | ||
| if args != nil { |
There was a problem hiding this comment.
We should be checking len(args) != 0 imo here. Just to exclude non-nil but still empty args
There was a problem hiding this comment.
@Darkren But what if people want to run an app with no args?
added 3 commits
May 15, 2020 17:21
* Separated app-associated functionality within /pkg/visor into /pkg/app/launcher. * Added the concept of visor.BaseConfig() to simplify obtaining default values. * Made startup/shutdown logic modular and introduced init and shutdown stacks. * Shutdown now uses module-based timeouts and wait groups.
evanlinjin
force-pushed
the
feature/improve-config-#339
branch
from
47b6fb0 to
912fe09
Compare
nkryuchkov
reviewed
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339 fixes #173 fixes #170
Changes:
/pkg/visorinto/pkg/app/launcher.visor.BaseConfig()to simplify obtaining default values.