Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Loop to RouteGroup for hypervisor endpoints and RPC. #180

Closed
1 task
evanlinjin opened this issue Mar 3, 2020 · 2 comments · Fixed by #207
Closed
1 task

Rename Loop to RouteGroup for hypervisor endpoints and RPC. #180

evanlinjin opened this issue Mar 3, 2020 · 2 comments · Fixed by #207
Assignees
@Kifen

Comments

@evanlinjin
Copy link
Contributor

TODO

  • Rename Loop to RouteGroup for hypervisor endpoints and RPC.

Originally posted by @evanlinjin in #166 (comment)
@Kifen
Copy link
Contributor

Kifen commented Mar 5, 2020 •
edited
Loading

@evanlinjin how about the function in hypervisor getLoop, should it be renamed to getRouteGroup? Also should the function Loops in RPCClient interface be renamed to RouteGroups ?

@jdknives
Copy link
Member

jdknives commented Mar 5, 2020

I think that would make sense.

@Kifen Kifen mentioned this issue Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kifen Kifen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed loop to routegroup for hypervisor endpoints, function names, struct types and comments.
3 participants
@evanlinjin @Kifen @jdknives