Renamed loop to routegroup for hypervisor endpoints, function names, struct types and comments.
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kifen
requested review from
evanlinjin,
nkryuchkov and
jdknives
and removed request for
nkryuchkov
|
I think it would make sense to rename the other occurences of loop in the codebase as well (if they relate to the skywire concept of loop/routegroup). Here are few of them returned from grep: @evanlinjin you agree? |
Yes. However we got to be careful, some references are meant to stay and they refer to |
evanlinjin
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Yes
Fixes #180
Changes:
How to test this PR: