Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snettest.Env should not be dialing to an actual address resolver. #395

Closed
evanlinjin opened this issue Jun 7, 2020 · 0 comments
Closed

snettest.Env should not be dialing to an actual address resolver. #395

evanlinjin opened this issue Jun 7, 2020 · 0 comments
Assignees
@nkryuchkov
Labels
bug Something isn't working

Comments

@evanlinjin
Copy link
Contributor

Describe the bug

As mentioned on Discord:

Is there an alternative to dialing to an actual address resolver for the snettest package?
This package is used in many unit tests and various pseudo-integration tests and should not be dependent on an actual service.

https://github.com/SkycoinProject/skywire-mainnet/blob/62cb7b87d11c716a15fc7e9d54955132f6c5391f/pkg/snet/snettest/env.go#L99-L102
@evanlinjin evanlinjin added the bug Something isn't working label Jun 7, 2020
evanlinjin added a commit that referenced this issue Jun 7, 2020
@evanlinjin
Tweaks as suggested by @nkryuchkov
67d5e6f 
Actual dialing to the snettest.Env struct has also been temporarily removed. This will be addressed in #395
@nkryuchkov nkryuchkov mentioned this issue Jun 30, 2020
Merged
jdknives pushed a commit that referenced this issue Oct 19, 2020
@evanlinjin
Tweaks as suggested by @nkryuchkov
425faa4 
Actual dialing to the snettest.Env struct has also been temporarily removed. This will be addressed in #395


Former-commit-id: 67d5e6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkryuchkov nkryuchkov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evanlinjin @nkryuchkov