Route redialing continues after app is closed

[jdknives]

Describe the bug
After requesting a route and closing the app that created a route, the visor keeps on retrying to redial for the old route. This prevents to dial for a new route for a while for me.

Environment information:

• OS:Mac OS X

• happens on fix/vpn-start-stop

Steps to Reproduce
Steps to reproduce the behavior:

1.Setup VPN client with remote PK
2. Start app
3. Stop app
4. Check logs
5. Start app with new PK set

Actual behavior
Visor keeps redialing for quite some time

Expected behavior
The visor stops when app requesting routes is closed or just does not try as often.

Possible implementation
Simplest fix would be to modify route redialing logic to only retry 4-5 times.

[jdknives]

This issue is actually not an issue with the redialing logic but the shutdown logic. The VPN is still running even though the shutdown signal was received by visor. Attaching logs, which show that the HTTP request only completes after 52s when I manually kill the VPN process.

log-vpn-client.txt