Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check
?Yes
Fixes #641 #636
Changes:
How to test this PR:
Repeat steps from the original ticket. Step 3 should complete and app should be restarted. Also VPN client should be closed on visor shut down without any duplicates. Also, previously issue could be reproduced not by changing the app arg, but just stopping it and refreshing page afterwards (when stop hung). This should work too, app should be stopped ok during dialing