New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put stcp at the end of the transport types list #1008

Merged

jdknives merged 1 commit into skycoin:develop from Senyoret1:stcp-position

Nov 19, 2021

+10 −1

Contributor

Senyoret1 commented Nov 18, 2021

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #1007

Changes:

If the Hypervisor API returns stcp as one of the available transport types, it is put at the bottom of the types list, in the popup used for creating new transports.

How to test this PR:
Use the Skywire manager to create a new transport. If the stcp is in the available types list, it should be at the bottom.

@jdknives Would you like something like “(for testing only)” added at the end?


          Put stcp at the end of the transport types list

511a32f

jdknives approved these changes

View reviewed changes

jdknives merged commit cf474fe into skycoin:develop

Member

jdknives commented Nov 19, 2021

@Senyoret1 should be sufficient for now without the for testing only added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet