Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/syslog #1013

Merged
merged 29 commits into from
Dec 8, 2021
Merged

Fix/syslog #1013

merged 29 commits into from
Dec 8, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Nov 24, 2021

Did you run make format && make check?
yes

Fixes #983

Changes:

  • Added syslog-ng.conf file
  • Added main syslog logger to NewProcLogger(), disc.NewHTTP(), dmsgc, and ClientFactory

How to test this PR:

  1. Checkout #dmsg-134 in dmsg
  2. In skywire uncomment replace github.com/skycoin/dmsg => ../dmsg in go.mod and run
    make dep
    
  3. Run
    make build
    
    sudo syslog-ng -f ./init/syslog-ng.conf -edv
    
  4. In a new terminal run
    ./skywire-visor -c skywire-config.json --syslog localhost:514
    
  5. Check the logs in a new terminal via
    sudo cat /var/log/skywire
    

Needs:
#dmsg-134

This commit adds the syslog-ng.conf config file to init folder.
This commit adds mLog parameter to NewProcLogger(). If the mlog is nil then a new master logger is created.
This commit updates the disc.NewHTTP() with a new parameter that takes a new parameter logger. We use nil so that the defalut logger will be used.
This commit adds a parameter masterLogger to New() in dmsgc. It also sets packagelogger to disc.NewHTTP and SetMasterLogger() to dmsgc.
This commit adds master logger to ClientFactory and ManagedTransportConfig.
@ersonp ersonp mentioned this pull request Nov 24, 2021
@ersonp ersonp marked this pull request as ready for review November 24, 2021 11:34
This commit adds master logger to router.Config and router. The master logger is used to create a logger with package logger for NewRouteGroup().
This commit adds master logger to rfclient.NewHTTP.
This commit adds master logger to httpauth, utclient and transport-discovery along with other required structs.
This commit adds package logger to the parameter of NewDmsgTrackerManager instead of nil.
This commit adds a new parameter mLog to NewAddressFilter() and uses that to get a PackageLogger for address-filter.
This commit adds a new parameter mLog to NewKCPConversationFilter() and uses that to get a PackageLogger for kcp-filter.
This commit adds a new parameter mLog to NewRPCGateway and uses that to get a PackageLogger for router-gateway.
This commit adds a new parameter mLog to NewKCPConversationFilter() and uses that to get a PackageLogger for kcp-filter.
This commit fixes the logs in managed transport along with other log related minor fixes in the transport package.
This commit fixes the retrier logger in addressresolver package.
This commit fixes the logs in Hypervisor and also updates NewUserManager and NewDmsgTrackerManager to take master logger as a parameter and use that to get a package logger.
@jdknives jdknives mentioned this pull request Dec 7, 2021
@jdknives jdknives merged commit ff76778 into skycoin:develop Dec 8, 2021
@ersonp ersonp deleted the fix/syslog branch April 11, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants