-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new/update flags on skywire-cli #1052
Conversation
cli_addr should actually be ":3545" I think it's equivalent to 0.0.0.0 for the ip address to be blank but the port is listed |
We need consistency in the default behavior for some things. Is enable-auth to be considered default? If so, can you make sure it is evenly implemented, it was changed to not enabled by default in the -p flag but the default when you give no arguments is enabled and can you put a flag for the config generation to |
As had conversation with Moses on matrix, we want these changes:
|
…lecte os | set enable and disable auth flag | remove -s flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright. Only need to double check we are not using the deprecated flag in Skybian still.
Did you run
make format && make check
?Fixes #1046 #1050 #1054 #1061
Changes:
--public-rpc
flag to change CLIAddr fromlocalhost:3435
to:3435
.--hypervisor-pks <visor-pk>
flag, that if key equal to visor PK, then change this visor to hypervisor.--vpn-server-enable
flag to make vpn-server app autostart attribute true--package
flag to distinguished between hypervisor and visor, and change its config output file name--output
or-o
flag, and if set was used then override-p
and-s
flagHow to test this PR:
make build
./skywire-cli config gen --public-rpc
:3435
skywire-cli config gen --hypervisor-pks <visor-pk> -ro skywire-config.json
[]
, and hypervisor config part should added to config file../skywire-cli config gen -r --vpn-server-enable
-pi
and-p
to check their different name-pir
or-sr
with-o config.json
flag to see override functionality