Windows installer #1060
Merged
Windows installer #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ opens browser to hypervisor UI
jdknives
approved these changes
Jan 28, 2022
internal/gui/gui.go
Outdated
| @@ -192,27 +190,6 @@ func handleVPNLinkButton(conf *visorconfig.V1) { | |||
| } | |||
| } | |||
|
|
|||
| // GetAvailPublicVPNServers gets all available public VPN server from service discovery URL | |||
| func GetAvailPublicVPNServers(conf *visorconfig.V1) []string { | |||
There was a problem hiding this comment.
Was supposed to be used for a quick connect functionality in the Systray application. So you could use the Systray directly without having to open the browser. Can likely be kept and used when we improve the Systray application.
There was a problem hiding this comment.
Oh, I didn't know about it. So I'll added it back.
Update:
Done. #e264ec5
ersonp
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?no
Fixes #745
Changes:
How to test this PR:
build:
Follow the instructions in scripts/win_installer/README.md
installer:
skywire, or runSkywiredirectly by start menu shortcutCurrent Shortcomings:
the executables are not by default in the PATHthe shortcut / launcher is blocked by the firewallSystray application #651 is not integrated into this yetuser must generate their own configuration (no auto-config currently)skywire-cli config genflag supporting windows installations #1061