skywire-cli flags for vpn ui and url #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdknives
reviewed
Feb 8, 2022
| if err != nil { | ||
| logger.Fatal("Failed to connect:", err) | ||
| } | ||
| url := fmt.Sprintf("http://127.0.0.1:8000/#/vpn/%s/", overview.PubKey.Hex()) |
There was a problem hiding this comment.
@0pcom is the hardcoded localhost IP here an issue for you? Should we pull this from the config directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesFixes #1079
Changes:
skywire-cliskywire-cli visor vpn-ui: for running VPN UI on browserskywire-cli visor vpn-url: for getting VPN URL on terminalHow to test this PR:
./skywire-cli visor vpn-uito open VPN UI on browser../skywire-cli visor vpn-urlto showing VPN URL on termiunal.