Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport transport deregistration logic #109

Merged
merged 4 commits into from
Jan 8, 2020
Merged

Backport transport deregistration logic #109

merged 4 commits into from
Jan 8, 2020

Conversation

Kifen
Copy link
Contributor

@Kifen Kifen commented Jan 7, 2020

Fixes #84

Changes:

  • Update transport deregistration logic

How to test this PR:

  •  make test

jdknives
jdknives requested changes Jan 7, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the transport manager_test should be copied over as well imo.

jdknives
jdknives reviewed Jan 7, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lint these changes before merging.

@jdknives jdknives merged commit b4df6ea into skycoin:milestone2 Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kifen @jdknives