New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dmsghttp-config.json file path in skywire config #1114

Merged

jdknives merged 2 commits into skycoin:develop from mrpalide:feature/fix-dmsghttp-config-path

Mar 2, 2022

Contributor

mrpalide commented Feb 25, 2022

Did you run make format && make check?

Changes:

set fix path for dmsghttp-config.json on skywire-config.json.

How to test this PR:

make build
./skywire-cli config gen -d to check dmsghttp_path field on generated configuration


          fix dmsghttp-config.json file path in skywire config

0a0384b

ersonp approved these changes

View reviewed changes

Contributor

ersonp commented Mar 1, 2022

Just a small question; are we using the path from the config anywhere? and if yes then just add a comment here.


          add change log to v1.go

624d168

jdknives approved these changes

View reviewed changes

jdknives merged commit ce9a97c into skycoin:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet