Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/close vpn conn gracefully #1168

Merged
merged 2 commits into from
May 3, 2022
Merged

Fix/close vpn conn gracefully #1168

merged 2 commits into from
May 3, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Apr 29, 2022 •
edited
Loading

Did you run make format && make check?
yes

Fixes #1095

Changes:

  • Removed mutex lock

How to test this PR:

  1. Start vpn-server on visor A
  2. Start Visor B and connect to the vpn-server
  3. Stop the vpn-client on visor B
  4. Check logs of visor B

ersonp added 2 commits April 29, 2022 13:30
@ersonp
Fix handlePacket
54360ba 
This commit fixes the blocking in close packet case in the method handlePacket by removing the mutex lock.

This mutex lock was causing the close logic of the closeInitiator to get stuck in the method waitForCloseRouteGroup.
@ersonp
Minor log fix
808a100
@ersonp ersonp marked this pull request as ready for review May 3, 2022 09:32
@mrpalide mrpalide merged commit a78ba8b into skycoin:develop May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @mrpalide