Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dmsgpty #117

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Fix dmsgpty #117

merged 2 commits into from
Jan 16, 2020

Conversation

Kifen
Copy link
Contributor

@Kifen Kifen commented Jan 14, 2020

Fixes # https://github.com/SkycoinPro/skywire-services/issues/39

Changes:

  • Changed node.UnlinkSocketFIles() to UnlinkSocketFIles()
  • Refactored the implementation of unlinking socket files in /skywire-mainnet/cmd/skywire-visor/commands/root.go

How to test this PR:
Run an integration env, and ensure dmsgpty is set in config. Run dmsgpty

@Kifen Kifen requested review from jdknives, nkryuchkov and Darkren and removed request for nkryuchkov January 14, 2020 12:14
evanlinjin
evanlinjin approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@evanlinjin
Copy link
Contributor

We need to have the interactive environment updated to have dmgpty before this PR can be merged.

Darkren
Darkren approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@Darkren Darkren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@evanlinjin evanlinjin merged commit 9005759 into skycoin:milestone2 Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@Darkren Darkren Darkren approved these changes

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kifen @evanlinjin @Darkren