Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config fallback in cli #1193

Merged
merged 3 commits into from
May 13, 2022
Merged

Fix config fallback in cli #1193

merged 3 commits into from
May 13, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented May 12, 2022

Did you run make format && make check?
yes

Fixes #1192

Changes:

  • Fixed output var
  • Fixed conf fallback logic

How to test this PR:

  1. Run ./skywire-cli config gen -rt -a test.skywire.dev
  2. Check if it works

ersonp added 3 commits May 12, 2022 16:32
@ersonp
Fix Falling back on hardcoded servers
bebefcd 
This commit fixes the fallback logic by falling back on all config urls and not just of prod.
@ersonp
Fix var output
4e5616c 
This commit fixes the case where the var output is printed empty when default value of the output is used.
@ersonp
Minor systray fix
7248ee1
@mrpalide mrpalide merged commit 4992c3d into skycoin:develop May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @mrpalide