Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vpn server close #1212

Merged
merged 4 commits into from
May 19, 2022
Merged

Fix/vpn server close #1212

merged 4 commits into from
May 19, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented May 19, 2022

Did you run make format && make check?
yes

Fixes #1153

Changes:

  • Reverted network changes on vpn-server close

How to test this PR:

  1. Start visor sudo ./skywire-visor -c skywire-config.json
  2. Check the outputs of commands
    sysctl net.ipv4.ip_forward
    sysctl net.ipv6.conf.all.forwarding
    iptables -L | grep "Chain FORWARD" | tr -d '()' | awk '{print $4}'
  3. Start vpn-server
  4. Check the outputs of commands
    sysctl net.ipv4.ip_forward
    sysctl net.ipv6.conf.all.forwarding
    iptables -L | grep "Chain FORWARD" | tr -d '()' | awk '{print $4}'
  5. Stop vpn-server
  6. Check the outputs of commands
    sysctl net.ipv4.ip_forward
    sysctl net.ipv6.conf.all.forwarding
    iptables -L | grep "Chain FORWARD" | tr -d '()' | awk '{print $4}'
  7. Everything should be reverted

ersonp added 3 commits May 19, 2022 16:44
This commit resets all the changes on Close() made to ip forwarding, ip masquerading and iptables while starting the vpn-server.
@ersonp ersonp marked this pull request as ready for review May 19, 2022 11:51
@mrpalide mrpalide merged commit d091c8c into skycoin:develop May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants