Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vpn reconnecting status #1222

Merged
merged 2 commits into from
May 25, 2022
Merged

Fix vpn reconnecting status #1222

merged 2 commits into from
May 25, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented May 25, 2022

Did you run make format && make check?
yes

Fixes #1221

Changes:

  • Removed unused status AppStatusReconnecting
  • Fixed status for AppDetailedStatusVPNReconnecting

How to test this PR:

  1. Start visor
  2. Connect to a vpn-server that is not online
  3. keep checking the API http://localhost:8000/api/visors/<pk>/summary
  4. Check the apps UI in visor details
  5. Check if the status is 3 for the detailed status Connection failed, reconnecting

ersonp added 2 commits May 25, 2022 12:19
@ersonp
Remove AppStatusReconnecting
e1d35de 
This commit removes the AppStatus AppStatusReconnecting as we are using AppStatusStarting instead.
@ersonp
Fix AppDetailedStatusVPNReconnecting app status
2c2009b
@mrpalide mrpalide merged commit cd14ca2 into skycoin:develop May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @mrpalide