New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`--binpath` flag #1223

Merged

ersonp merged 1 commit into skycoin:develop from mrpalide:feature/flag-bin-path-and-build-musl-on-release

May 25, 2022

Contributor

mrpalide commented May 25, 2022

Did you run make format && make check? Yes

Fixes #1219

Changes:

add --binpath flag to set it during generate config

How to test this PR:

clone this dmsg PRs branch.
clone current PR branch, comment out //replace dmsg... on go.mod, then make dep
build binaries
use ./skywire-cli config gen --binpath /foo/bar to check bin_path value on config
run a visor, open dmsgpty full terminal to check DMSGPTYTERM env variable set there


          set --binpath flag

8b28434

mrpalide mentioned this pull request

set DMSGPTYTERM env variable on starting UI skycoin/dmsg#174

Merged

ersonp approved these changes

View reviewed changes

ersonp merged commit 76f20b0 into skycoin:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet