Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vpn-server close err #1227

Merged
merged 3 commits into from
May 26, 2022
Merged

Fix vpn-server close err #1227

merged 3 commits into from
May 26, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented May 26, 2022

Did you run make format && make check?
yes

Fixes #942

Changes:

  • Fixed warn log in method Read of RPCIngressGateway
  • Added vpn-server stopped error

How to test this PR:

  1. Start vpn-server on visor A
  2. Start vpn-client on visor B and connect to the vpn-server of visor A
  3. Stop the vpn-server on visor A
  4. See error on UI

ersonp added 3 commits May 26, 2022 12:33
This commit fixes the warn log on error on conn.Read to not print anything if the conn is already closed.
This commit adds and send the error errVPNServerClosed to proc whenever the server that client is connected to closes.

We are using the condition err.Error() == io.EOF.Error() instead of errors.Is(err, io.EOF) beacause the later one does not work.
@jdknives jdknives merged commit 668d5ad into skycoin:develop May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants