Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the update and restart buttons #1239

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Remove the update and restart buttons #1239

merged 2 commits into from
Jun 2, 2022

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #1098

Changes:

  • Now the restart and update buttons are hidden if the visor has any of the following values in the build_tag property: windows, win, mac, macos, mac os, darwin.

How to test this PR:
Run a visor with any of the indicated build tags. The restart and update buttons should not be visible in the options menu of the visor details page, in the Skywire Manager. Also, in the visor list, the button for updating all online visors should not be visible if all the online visor have any of those tags. If there are some visors with the tags, only those visors are updated.

NOTE: maybe there are other visors for which the buttons should be removed too.

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be correct, but someone should test this.

@mrpalide
Copy link
Contributor

mrpalide commented Jun 1, 2022

I can confirm that reboot and update buttons not available if build_tag be windows or darwin or others that mention above, but unfortunately other buttons not work, except change language. Tested on mac|chrome and arch|firefox.

Mac | Chrome:

mac_chrome.mov

@Senyoret1
Copy link
Contributor Author

Senyoret1 commented Jun 1, 2022

@mrpalide Solved in the last commit.

One thing that got my atention while making the changes was the terminal button. Could you please check if it should be removed for some builds? I have not made changes to it.

@jdknives jdknives merged commit 036769f into skycoin:develop Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants