-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dmsgpty-cli
to skywire-cli
#1250
add dmsgpty-cli
to skywire-cli
#1250
Conversation
dmsgpty
simple command executor to skywire-cli
dmsgpty-cli
to skywire-cli
Getting this when trying to connect to the visor on
|
When you run your hypervisor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised that you couldn't import the dmsgpty-client command directly from the other repo; but it may be better to do it this way.
It works great, and it's impressive that it did not actually take you very long at all to make it work.
I've been waiting a long time for this exact functionality, thanks very much for your work here.
Did you run
make format && make check
? YesFixes #863
Changes:
dmsgpty
command groups toskywire-cli
as follow:skywire-cli dmsgpty list
to get list of all remote visor connected to hypervisorskywire-cli dmsgpty start <pk>
to start dmsgpty command line interface. Just note that if remote visor connection lost, then its appear onskywire-cli dmsgpyt list
command yet, but when trying to start dmsgpty, get error after a while (about 10 second).How to test this PR:
skywire-cli dmsgpty list
check that visor connected and availableskywire-cli dmsgpty start <pk>
to run dmsgpty command line interface of remote visor in your terminalScreenCast:
dmsgpty.mp4