Clean logs #1252

ersonp · 2022-06-10T06:53:13Z

Did you run make format && make check?
yes

Changes:

Changed repetitive logs to trace
Changed Extra-informative logs to debug
Added Info logs where needed
Fixed some closing logs
Set Stdout of proc to Debug
Set Stderr of proc to Error
Removed logs from apps
Changed info logs to fmt.Print in apps
Changed error logs to print() in apps
Removed unnecessary lock and unlock logs

How to test this PR:

Checkout #skywire-utilities-25
Checkout #dmsg-176
In dmsg in the file go.mod uncomment replace github.com/skycoin/skywire-utilities => ../skywire-utilities and run make dep
In skywire in the file go.mod uncomment replace github.com/skycoin/skywire-utilities => ../skywire-utilities and replace github.com/skycoin/dmsg => ../dmsg and run make dep; make build
Set the log_level in the config to info, debug, and trace and test the functionalities and apps of the visor
Check logs

This commit changes the info logs to debug and deletes the logs from the method readPacket as they are repetative and don't offer much in terms of debugging.

This commit changes the info logs to debug and deletes the logs that are just used to notify about lock and unlock..

This commit changes the info logs to debug and and along with that adds a WithField method to the logs of the methods with the func as the field insted of having the name of the method in the log.

This commit changes the info logs to debug and adds a startup finished info log.

This commit fixes the error log by printing it only if the error is not equal to context cancled.

This commit removes the Requesting and Obtained log for summary via RPC as it is a recurring log and is not usefull.

This commit changes the log level of Stdout to Debug and Stderr to Error instead of both being Info.

This commit updates the vpn-client logs by printing the error logs with print() that uses the Stderr to write out the errors. We also get rid of *logrus.Logger in client as it was also writing logs to Stderr instead of Stdout as we need our non error logs to be.

This commit fixes the error log printed when the RouteGroup is already closed.

This commit fixes the entry log in the method RegisterEntry of HTTPClient by adding a String method to the reciever Service which returns a string of the Marshalled struct and also using the String method of the Addr struct inside it.

jdknives · 2022-06-15T14:36:24Z

[2022-06-15T16:33:38+02:00] INFO [buildinfo]:  version="v1.0.0-rc5-57-g5087c8a0" built on="2022-06-15T14:33:22Z" commit="5087c8a04000788d2d6745587cb097cb49f75346"
[2022-06-15T16:33:38+02:00] INFO [visor:config]: Reading config from file.
[2022-06-15T16:33:38+02:00] INFO [visor:config]: filepath="skywire-config.json"
[2022-06-15T16:33:38+02:00] INFO [visor:config]: config version: ="v1.0.0-rc5-57-g5087c8a0"
[2022-06-15T16:33:38+02:00] INFO [visor:startup]: Begin startup. public_key=0365e4bb732cdc979e6fd93e74e48f3e6f04df26554928e640e4794834bdf42e9a
[2022-06-15T16:33:46+02:00] INFO [visor]: Serving hypervisor... addr=":8000" tls=false
[2022-06-15T16:33:49+02:00] INFO [stun_client]: NAT Type: Restricted NAT
[2022-06-15T16:33:49+02:00] INFO [stun_client]: Public IP: 194.233.96.200:57759
[2022-06-15T16:33:49+02:00] INFO [visor:startup]: Startup complete.
[2022-06-15T16:33:51+02:00] WARN [public_autoconnect]: Failed to add transport to public visor error="save transport: mt.client.Dial: resolve PK: no entry for this PK" pk=03b5468ac5c19bc4ce14e759ff5f1fb78274a5ed615439f1be7af0da7e29ac4dec type="stcpr"
[2022-06-15T16:33:51+02:00] WARN [public_autoconnect]: Failed to add transport to public visor error="save transport: mt.client.Dial: resolve PK: no entry for this PK" pk=02111387c63780fcb82b6b841cb08b57a08985c466b55999f1a80be3524412bf94 type="stcpr"
^C[2022-06-15T16:33:55+02:00] INFO []: Closing with received signal. signal=interrupt
[2022-06-15T16:33:55+02:00] INFO [visor:shutdown]: Begin shutdown.
2022/06/15 16:33:55 rpc.Serve: accept:accept tcp 127.0.0.1:3435: use of closed network connection
[2022-06-15T16:33:56+02:00] INFO [visor:shutdown]: Shutdown complete. Goodbye!

The first five lines of logs can be simplified. No need to say we are reading config from file as its default behavior. Since visor and config version are the same, we can omit the second log of the version. Can print a log line if we update the config. Config path and version can be printed on the same line imo.

jdknives · 2022-06-15T14:38:34Z

I would also update documentation in the wiki with the new log level. Are we getting the debug logs in the hypervisor log endpoint or just info?

ersonp · 2022-06-15T14:43:22Z

I would also update documentation in the wiki with the new log level. Are we getting the debug logs in the hypervisor log endpoint or just info?

Yes, will update the wiki with the new log level.
And as for the second part if I understood you correctly, currently the hypervisor logs from chi are as info but as mentioned my @mrpalide that should be moved to debug and I'll work on it as soon as I fix some other issues.

ersonp · 2022-06-15T16:09:40Z

[2022-06-15T16:33:38+02:00] INFO [buildinfo]:  version="v1.0.0-rc5-57-g5087c8a0" built on="2022-06-15T14:33:22Z" commit="5087c8a04000788d2d6745587cb097cb49f75346"
[2022-06-15T16:33:38+02:00] INFO [visor:config]: Reading config from file.
[2022-06-15T16:33:38+02:00] INFO [visor:config]: filepath="skywire-config.json"
[2022-06-15T16:33:38+02:00] INFO [visor:config]: config version: ="v1.0.0-rc5-57-g5087c8a0"
[2022-06-15T16:33:38+02:00] INFO [visor:startup]: Begin startup. public_key=0365e4bb732cdc979e6fd93e74e48f3e6f04df26554928e640e4794834bdf42e9a
[2022-06-15T16:33:46+02:00] INFO [visor]: Serving hypervisor... addr=":8000" tls=false
[2022-06-15T16:33:49+02:00] INFO [stun_client]: NAT Type: Restricted NAT
[2022-06-15T16:33:49+02:00] INFO [stun_client]: Public IP: 194.233.96.200:57759
[2022-06-15T16:33:49+02:00] INFO [visor:startup]: Startup complete.
[2022-06-15T16:33:51+02:00] WARN [public_autoconnect]: Failed to add transport to public visor error="save transport: mt.client.Dial: resolve PK: no entry for this PK" pk=03b5468ac5c19bc4ce14e759ff5f1fb78274a5ed615439f1be7af0da7e29ac4dec type="stcpr"
[2022-06-15T16:33:51+02:00] WARN [public_autoconnect]: Failed to add transport to public visor error="save transport: mt.client.Dial: resolve PK: no entry for this PK" pk=02111387c63780fcb82b6b841cb08b57a08985c466b55999f1a80be3524412bf94 type="stcpr"
^C[2022-06-15T16:33:55+02:00] INFO []: Closing with received signal. signal=interrupt
[2022-06-15T16:33:55+02:00] INFO [visor:shutdown]: Begin shutdown.
2022/06/15 16:33:55 rpc.Serve: accept:accept tcp 127.0.0.1:3435: use of closed network connection
[2022-06-15T16:33:56+02:00] INFO [visor:shutdown]: Shutdown complete. Goodbye!

The first five lines of logs can be simplified. No need to say we are reading config from file as its default behavior. Since visor and config version are the same, we can omit the second log of the version. Can print a log line if we update the config. Config path and version can be printed on the same line imo.

The version log

[2022-06-15T16:33:38+02:00] INFO [buildinfo]:  version="v1.0.0-rc5-57-g5087c8a0" built on="2022-06-15T14:33:22Z" commit="5087c8a04000788d2d6745587cb097cb49f75346"

Fixed the first part but about the Config path and version being on the same line, I think it is better to keep them separate as the version is in the build info and the config path is basically the config info.

This commit fixes the vpn-client not working issue that was introduced by the commit 920461c since it passed eventSub to the appclient before running eventSub.OnTCPDial and eventSub.OnTCPClose which caused the vpn-client to not work as intended. We fix it by running them first before passing the eventSub to app.NewClient.

This commit adds a condition to use the logger middleware in chi only when the log level is either debug or trace.

ersonp added 7 commits June 10, 2022 12:05

Update router logs

9bab51a

Update managed_transport logs

01001cf

This commit changes the info logs to debug and deletes the logs from the method readPacket as they are repetative and don't offer much in terms of debugging.

Fix router logs

fdfd6ef

Update transport logs

f31cd94

This commit changes the info logs to debug and deletes the logs that are just used to notify about lock and unlock..

Update logs in package network

549c3b8

Update addrresolver logs

87432e5

This commit changes the info logs to debug and and along with that adds a WithField method to the logs of the methods with the func as the field insted of having the name of the method in the log.

Update module init logs

06e8cde

ersonp changed the title ~~Clean/logs~~ Clean logs Jun 10, 2022

ersonp added 22 commits June 10, 2022 12:29

Update logs in setup

6063de8

Update skychat print

04687a9

Update appserver logs

590e244

Update hypervisor logs

9b8f1bd

Update rpcutil logs

496f9ea

Update visor logs

fe22124

This commit changes the info logs to debug and adds a startup finished info log.

Update init logs

98124e9

Remove lock logs in transport

0f5b581

Update autoconnect log

24709ab

Print Removed rule log only when a rule is deleted

377ed3f

Update appnet logs

b68beaa

Fix autoconnect logs

c232d73

This commit fixes the error log by printing it only if the error is not equal to context cancled.

Update startup finished log

74b61da

Fix hypervisor logs

a0d17d2

This commit removes the Requesting and Obtained log for summary via RPC as it is a recurring log and is not usefull.

Update proc log levels

f39339b

This commit changes the log level of Stdout to Debug and Stderr to Error instead of both being Info.

Update vpn client logs

12f63b2

This commit updates the vpn-client logs by printing the error logs with print() that uses the Stderr to write out the errors. We also get rid of *logrus.Logger in client as it was also writing logs to Stderr instead of Stdout as we need our non error logs to be.

Fix log of method writePacket of the reciever RouteGroup

76f9caa

This commit fixes the error log printed when the RouteGroup is already closed.

Update vpn-client logs

2cb8922

Update vpn-server logs

d0483b3

Add permission denied error in server

f2f8e22

Add appCl.SetError in vpn-client cmd

920461c

Fix appCl.SetError

557942b

ersonp added 7 commits June 13, 2022 16:54

Update logs in skysocks

5be4768

Update skychat logs

acba5cb

Merge branch 'develop' into clean/logs

5b7aaa8

Use logging from skywire-utilities

79b8006

Minor Changes

d1993e0

Minor logs fixes in vpn-client

8f0f1b9

Minor fixes

ddbdb6c

This was referenced Jun 15, 2022

Feat logging skycoin/skywire-utilities#25

Merged

Update logs skycoin/dmsg#176

Merged

ersonp marked this pull request as ready for review June 15, 2022 09:08

ersonp added 6 commits June 15, 2022 15:20

Change the SUDPH unabailable log to warn

4c730fe

Fix EnableIPMasquerading issue

e1fc410

Fix entry log

5087c8a

This commit fixes the entry log in the method RegisterEntry of HTTPClient by adding a String method to the reciever Service which returns a string of the Marshalled struct and also using the String method of the Addr struct inside it.

Minor fix

15a9d2e

Minor fix in EnableIPMasquerading

23e242f

Minor fix in getIPForwardingValue

8a5f825

Fix startup logs

442f740

ersonp added 8 commits June 16, 2022 10:32

Remove test logs

712f9b7

Update chi logger

a329bae

This commit adds a condition to use the logger middleware in chi only when the log level is either debug or trace.

Update skywire-utilities

a16a3aa

Update dmsg

f95406b

Fix test

0b9aaca

Update changelog

0791892

Fix mac and win test

b8f0d66

jdknives merged commit afed86e into skycoin:develop Jun 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean logs #1252

Clean logs #1252

ersonp commented Jun 10, 2022 •

edited

Loading

jdknives commented Jun 15, 2022

jdknives commented Jun 15, 2022

ersonp commented Jun 15, 2022 •

edited

Loading

ersonp commented Jun 15, 2022

Clean logs #1252

Clean logs #1252

Conversation

ersonp commented Jun 10, 2022 • edited Loading

jdknives commented Jun 15, 2022

jdknives commented Jun 15, 2022

ersonp commented Jun 15, 2022 • edited Loading

ersonp commented Jun 15, 2022

ersonp commented Jun 10, 2022 •

edited

Loading

ersonp commented Jun 15, 2022 •

edited

Loading