Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix halt command #1310

Merged
merged 3 commits into from
Aug 2, 2022
Merged

fix halt command #1310

merged 3 commits into from
Aug 2, 2022

Conversation

mrpalide
Copy link
Contributor

Did you run make format && make check? Yes

Fixes #1307

Changes:

  • add hypervisor module to pushCloseStack
  • add os.Exit(0) to Shutdown method

How to test this PR:

  • make build or make build-systray
  • run visor
  • in other terminal, run ./skywire-cli visor halt and check logs

@0pcom 0pcom self-requested a review July 14, 2022 12:52
0pcom
0pcom approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested and it works well, solves the issue.

I have not tested in the context of the systray, only with make run-source

this should be merged (after appveyor can build it)

@0pcom 0pcom mentioned this pull request Aug 2, 2022
Closed
@0pcom 0pcom merged commit de50023 into skycoin:develop Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0pcom 0pcom 0pcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrpalide @0pcom