Fix/disable keepalives #1315
Merged
Fix/disable keepalives #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the http transport keepalives to prevent all clients having permanent open connections to the deployment
mrpalide
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Yes
Fixes #1314
Changes:
http.TransportkeepalivesHow to test this PR:
This was tested with running a visor against production deployment while looping over
netstat -ntpw | grep skywire-visor. Without these changes, the visor has permanently 3-5 connections to the deployment open while after these changes, there is only one permanent connection to a given dmsg server.Note: We need to think about if the additional overhead of re-establishing connections is worth the improvement in concurrent connections to our loadbalancer.