Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable autopeering via environmental variable #1342

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented Aug 18, 2022

The reasoning behind this PR is that I was unable to successfully modify the systemd service for skywire via a drop-in override configuration file to change ExecStart to include the -m flag for enabling the autopeering ; nor was I able to render an env in ExecStart to provide the -m flag. The variable could only render the flag in quotes, at best, which does not work with cobra.

My solution to this is to set the env either in the systemd drop-in ; and have the visor detect this env directly rather than requiring it's flag.

The default value of the -m flag for skywire-visor is changed to true if the AUTOPEER env equals the string "1"

Did you run make format && make check?
yes

Changes:

  • activate autopeering on AUTOPEER=1 if SKYBIAN=true

How to test this PR:

AUTOPEER=1 SKYBIAN=true skywire-visor --all

@jdknives jdknives merged commit 7e07d1c into develop Aug 19, 2022
@jdknives jdknives deleted the fix/autopeering branch August 19, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants