Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/cli json output #1346

Merged
merged 33 commits into from
Aug 31, 2022
Merged

Feat/cli json output #1346

merged 33 commits into from
Aug 31, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Aug 29, 2022 •
edited
Loading

Did you run make format && make check?
yes

Fixes #

Changes:

  • Added global flag --json to skywire-cli
  • Updated skywire-cli visor route add-rule
  • Removed depreciated flag --public from skywire-cli visor tp add

How to test this PR:

  1. Test output of all subcommands under skywire-cli dmsgpty with and without --json flag
  2. Test output of all subcommands under skywire-cli visor with and without --json flag
  3. Test output of all subcommands under skywire-cli vpn with and without --json flag
  4. Test output of all subcommands under skywire-cli rtfind with and without --json flag
  5. Test output of all subcommands under skywire-cli mdisc with and without --json flag

ersonp added 30 commits August 26, 2022 12:47
@ersonp
Add global flag --json to cli
94be372
@ersonp
Update pkCmd
3aab3a1
@ersonp
Add func PrintFatalError
88a0968
@ersonp
Minor update
6509b67
@ersonp
Update hvpkCmd
e8ebecf
@ersonp
Update chvpkCmd
1930806
@ersonp
Update summaryCmd
1893520
@ersonp
Update buildInfoCmd
fd04c2c
@ersonp
Use Catch instead of PrintFatalError
763efae 
This commit removes the new function PrintFatalError and uses Catch in it's place. The func Catch is now updated to work with the new json flag.
@ersonp
Add func PrintError
da4f7da
@ersonp
Update command lsAppsCmd
3d67b08
@ersonp
Update start, stop, setAutoStart and logs command
066b905
@ersonp
Update visor execCmd
8d1c6f9
@ersonp
Update lsRulesCmd
0405775
@ersonp
Update rmRuleCmd
90ea771
@ersonp
Fix and update addRuleCmd
8579a20 
This commit seperates the add-rule command into three more subcommands app, fwd and intfwd. This is done in order to declutter the original implementation that only had app and intfwd where the latter was incorrectly named as fwd.

We also update printRoutingRules to fix the previously wrongly named printFwdRule and add printIntFwdRule.

We also fix the error catching in funcs parseUint, ParsePK and ParseUUID.
@ersonp
Update shutdownCmd
e07bc6d
@ersonp
Update startCmd
8f6b9d2
@ersonp
Update lsTypesCmd
32d9fc1
@ersonp
Update PrintTransports
223125f
@ersonp
Remove depreciated flag public from tp
52d0316
@ersonp
Update PrintTransportEntries
040baf0
@ersonp
Make format
94eba37
@ersonp
Add changelog
2c3f476
@ersonp
Update dmsgURLCmd
8f9cabe
@ersonp
Update visorsCmd
236664b
@ersonp
Update vpnUICmd
f5c6b02
@ersonp
Update vpnURLCmd
8b6e111
@ersonp
Update vpnListCmd
f720cc4
@ersonp
Update vpnStartCmd and vpnStopCmd
43d3744
@0pcom 0pcom self-requested a review August 31, 2022 18:21
0pcom
0pcom approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved

@0pcom 0pcom merged commit c97f05c into skycoin:develop Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0pcom 0pcom 0pcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @0pcom