Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cli json #1354

Merged
merged 7 commits into from
Sep 13, 2022
Merged

Fix/cli json #1354

merged 7 commits into from
Sep 13, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Sep 9, 2022

Did you run make format && make check?
yes

Fixes #

Changes:

  • Renamed PrintError to PrintFatalError
  • Updated comments of PrintOutput and CLIOutput
  • Fixed vpnStartCmd json output
  • Fixed addTpCmd json output
  • Fixed rmTpCmd json output
  • Fixed hvpkCmd json output
  • Fixed pkCmd json output

How to test this PR:

@0pcom 0pcom self-requested a review September 13, 2022 17:45
0pcom
0pcom approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

@0pcom 0pcom merged commit 3bc6cb4 into skycoin:develop Sep 13, 2022
jdknives pushed a commit that referenced this pull request Sep 15, 2022
@ersonp
Fix/cli json (#1354)
2b2a204 
* Fix pkCmd

* Fix hvpkCmd

* Fix rmTpCmd

* Fix addTpCmd

* Fix vpnStartCmd

* Update comments of PrintOutput and CLIOutput

* Rename PrintError to PrintFatalError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0pcom 0pcom 0pcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @0pcom