Fix StartVPNCient logic #1366
Merged
Fix StartVPNCient logic #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the logic in StartVPNClient where we assumed that the first app in the app list will always be vpn-client and based the logic around it. It would fail if the vpn-client wasn't the first app. Now this has been fixed and we check the whole list of apps to see if vpn-client is available and start it only if it is.
mrpalide
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Fixes #1359 (only fixes the logic in StartVPNCient)
Changes:
StartVPNCientHow to test this PR:
vpn-servervpn-clientvpn-clientrunskywire-cli vpn start <server-pk>cnad see if it worksvisor-config.jsonand try agan