Fix negative waitgroup #1372
Merged
Fix negative waitgroup #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the negative waitgroup error by using a ready channel and ready once instead of using the waitgroup as it fits the requirement better allong with fixing the issue with negative waitgroup.
This commit adds the new makefile rule build-race to build binaries with -race flag to use in the docker images of e2e and integration. We also update the rule build-deploy to use the rule host-apps-deploy instead and removing the commands to build the apps in it as they were not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Fixes #1370
Changes:
build-raceHow to test this PR: