Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add param customCommand for PtyUI.Handler #1383

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Add param customCommand for PtyUI.Handler #1383

merged 2 commits into from
Oct 7, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Oct 7, 2022

Did you run make format && make check?

Fixes #

Changes:

  • Update dmsg
  • Added param customCommand for PtyUI.Handler

How to test this PR:

  1. In dmsg checkout #dmsg-193
  2. In skywire uncomment replace github.com/skycoin/dmsg => ../dmsg in go.mod and run make dep
  3. Open hypervisor and from the top right corner select update
  4. Check if the correct commands were executed on the PTY (refer the usage with develop both should be the same as the commands may not work as they are meant for packages)

@ersonp ersonp mentioned this pull request Oct 7, 2022
Merged
@ersonp ersonp marked this pull request as ready for review October 7, 2022 11:12
@mrpalide mrpalide merged commit 90a0b2f into skycoin:develop Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @mrpalide